crypto: forward auth tag to OpenSSL immediately #58547
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This change simplifies the AEAD implementation. Instead of storing the authentication tag when the user calls `setAuthTag()` and passing it to OpenSSL later in `MaybePassAuthTagToOpenSSL()`, the modified code forwards it to OpenSSL from within `setAuthTag()` already, removing the need to store it. For clarity, I have also renamed the possible `AuthTagState` values to better reflect the actual state of the authentication tag. I assume that we did not originally do this due to issues with some old versions of OpenSSL when reordering certain function calls, but even with the recent additions I made to the relevant test (namely, 1ef9923 and 53944c4), it seems to pass in both OpenSSL 3 and OpenSSL 1.1.1 with this simplification.
|
Review requested:
|
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #58547 +/- ##
==========================================
- Coverage 90.23% 90.22% -0.01%
==========================================
Files 635 635
Lines 187580 187557 -23
Branches 36860 36852 -8
==========================================
- Hits 169265 169226 -39
+ Misses 11101 11095 -6
- Partials 7214 7236 +22
🚀 New features to boost your workflow:
|
panva
approved these changes
Jun 1, 2025
jasnell
approved these changes
Jun 1, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change simplifies the C++ AEAD implementation. Instead of storing the authentication tag when the user calls
setAuthTag()and passing it to OpenSSL later inMaybePassAuthTagToOpenSSL(), the modified code forwards it to OpenSSL from withinsetAuthTag()already, removing the need to store it.For clarity, I have also renamed the possible
AuthTagStatevalues to better reflect the actual state of the authentication tag.I assume that we did not originally do this due to issues with some old versions of OpenSSL when reordering certain function calls, but even with the recent additions I made to the relevant test (namely, 1ef9923 and 53944c4), it seems to pass in both OpenSSL 3 and OpenSSL 1.1.1 with this simplification.